Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: fix check disk quota routine block when some engine is importing (#44877) #44880

Merged
merged 8 commits into from
Jun 30, 2023
Merged

lightning: fix check disk quota routine block when some engine is importing (#44877) #44880

merged 8 commits into from
Jun 30, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #44877

What problem does this PR solve?

Issue Number: close #44867

Problem Summary:

What is changed and how it works?

  • make pebble db a atomic reference to avoid lock when check disk quota

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix check disk quota routine block when some engine is importing

@D3Hunter @ti-chi-bot
This is an automated cherry-pick of pingcap#44877
33bcf6c 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 21, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Jun 21, 2023
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 21, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 26, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 29, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 29, 2023
@D3Hunter
Copy link
Contributor

/run-integration-br-test

@D3Hunter
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 29, 2023
@D3Hunter
Copy link
Contributor

/retest

@lance6716
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 29, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 29, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-29 08:49:11.666074246 +0000 UTC m=+870317.067324689: ☑️ agreed by D3Hunter.
  • 2023-06-29 09:15:26.4870595 +0000 UTC m=+871891.888309949: ☑️ agreed by lance6716.

@D3Hunter
Copy link
Contributor

/run-integration-br-test

1 similar comment
@purelind
Copy link
Contributor

/run-integration-br-test

@D3Hunter
Copy link
Contributor

/run-integration-br-test

1 similar comment
@D3Hunter
Copy link
Contributor

/run-integration-br-test

@D3Hunter
Copy link
Contributor

/run-integration-br-test

4 similar comments
@D3Hunter
Copy link
Contributor

/run-integration-br-test

@D3Hunter
Copy link
Contributor

/run-integration-br-test

@D3Hunter
Copy link
Contributor

/run-integration-br-test

@D3Hunter
Copy link
Contributor

/run-integration-br-test

@D3Hunter
FOR DEBUG
ba083c4 
FOR DEBUG

FOR DEBUG
@D3Hunter
Revert "FOR DEBUG"
804f37e 
This reverts commit ba083c4.
@D3Hunter D3Hunter force-pushed the cherry-pick-44877-to-release-6.1 branch from 5b0d7b5 to 804f37e Compare June 29, 2023 14:38
@D3Hunter
Copy link
Contributor

D3Hunter commented Jun 29, 2023 •
edited
Loading

ci success after add some debug output, not sure why. will revert debug output and run again
https://ci.pingcap.net/blue/organizations/jenkins/br_ghpr_unit_and_integration_test/detail/br_ghpr_unit_and_integration_test/16027/pipeline/119

@D3Hunter
Copy link
Contributor

/run-integration-br-test

@D3Hunter
Copy link
Contributor

ci pass https://ci.pingcap.net/blue/organizations/jenkins/br_ghpr_unit_and_integration_test/detail/br_ghpr_unit_and_integration_test/16028/pipeline/

@D3Hunter
Copy link
Contributor

/retest

@D3Hunter
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 29, 2023
@D3Hunter
Copy link
Contributor

/retest

1 similar comment
@D3Hunter
Copy link
Contributor

/retest

GMHDBJD
GMHDBJD approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, GMHDBJD, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [D3Hunter,GMHDBJD,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit ae39052 into pingcap:release-6.1 Jun 30, 2023
@ti-chi-bot ti-chi-bot added cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. labels Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D3Hunter D3Hunter D3Hunter approved these changes

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees

@D3Hunter D3Hunter

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @D3Hunter @lance6716 @purelind @GMHDBJD